[PATCH] D103700: [LV] Fix bug when unrolling (only) a loop with non-latch exit

[Stefan Pintilie via Phabricator via llvm-commits]

stefanp added a comment.

In D103700#2799532 <https://reviews.llvm.org/D103700#2799532>, @nemanjai wrote:

> In D103700#2799340 <https://reviews.llvm.org/D103700#2799340>, @reames wrote:
>
>> In D103700#2799338 <https://reviews.llvm.org/D103700#2799338>, @nemanjai wrote:
>>
>>> We will be happy to test this on both our LE and BE systems. @stefanp do you have time to test this out or should I do it?
>>
>> Seems like overkill for this one given the change is trivial and the test is target independent.
>>
>> I'd save that for when I go to reapply the original patch that exposed this.
>
> Oh, sorry. I meant to say that we'd test with this patch and the reverted one applied together.

I've put the original patch as well as this fix together and I've run the buildbot that failed last time and everything passed.

In D103700#2799532 <https://reviews.llvm.org/D103700#2799532>, @nemanjai wrote:

> In D103700#2799340 <https://reviews.llvm.org/D103700#2799340>, @reames wrote:
>
>> In D103700#2799338 <https://reviews.llvm.org/D103700#2799338>, @nemanjai wrote:
>>
>>> We will be happy to test this on both our LE and BE systems. @stefanp do you have time to test this out or should I do it?
>>
>> Seems like overkill for this one given the change is trivial and the test is target independent.
>>
>> I'd save that for when I go to reapply the original patch that exposed this.
>
> Oh, sorry. I meant to say that we'd test with this patch and the reverted one applied together.

I added both patches and I did a quick test on the Big Endian Power PC buildbot machine.
This patch does seem to fix the original issue. However, after adding the two patches I have 4  new LIT test failues:

  LLVM :: Transforms/LoopVectorize/first-order-recurrence-complex.ll
  LLVM :: Transforms/LoopVectorize/loop-form.ll
  LLVM :: Transforms/LoopVectorize/multiple-exits-versioning.ll
  LLVM :: Transforms/LoopVectorize/unroll_nonlatch.ll


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103700/new/

https://reviews.llvm.org/D103700