[PATCH] D103743: [RISCV] Optimize bitwise and with constant for the Zbs extension

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 7 07:52:57 PDT 2021


benshi001 added a comment.

In D103743#2802540 <https://reviews.llvm.org/D103743#2802540>, @luismarques wrote:

> Are you planning on extending this to use bclriw on RV64? (Would that clash with the use of tablegen? Personally, I tend to find C++ custom lowering of longer stuff easier to read and more cohesive, not sure how others feel)

I have not consider BSETIW/BINVIW/BCLRIW, maybe I will do it in next patch. And this patch will just focuses on BCLRI.

I do not like C++ custom lowering for that, since it needs even more lines than current form.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103743/new/

https://reviews.llvm.org/D103743



More information about the llvm-commits mailing list