[PATCH] D102760: [llvm] Let SmallVector construct from any Iterable

Mon Jun 7 07:46:45 PDT 2021

gchatelet abandoned this revision.
gchatelet added a comment.

In D102760#2802520 <https://reviews.llvm.org/D102760#2802520>, @Quuxplusone wrote:

> @gchatelet: Thanks for the link to D102679 <https://reviews.llvm.org/D102679> — that seems like very relevant background info I didn't have!  Having looked through D102679 <https://reviews.llvm.org/D102679>, though, I don't see how it would benefit from D102760 <https://reviews.llvm.org/D102760> — in fact, D102679 <https://reviews.llvm.org/D102679> updates some tests to wisely //stop// depending on the ability to construct `SmallVector` from a range (and goes to using begin/end pairs instead — good!).

Yes these (recent) changes are based on your comments : )

> So I think D102679 <https://reviews.llvm.org/D102679> is a good idea (modulo the review comments I just left), and I continue to think that this D102760 <https://reviews.llvm.org/D102760> is a bad idea that should be abandoned.

This is my plan indeed. Thx for your insights. I really appreciate it.
I wanted to see the impact of removing the constructor first, it's very minor so I'll go ahead and abandon this change.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102760/new/

https://reviews.llvm.org/D102760