[PATCH] D103811: [docs] Set Phabricator as the tool for pre-commit code reviews
Krzysztof Parzyszek via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 7 07:02:31 PDT 2021
kparzysz created this revision.
kparzysz added reviewers: lattner, dblaikie.
kparzysz requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
This is a follow-up to the discussions about deprecating email code reviews in favor of Phabricator:
https://lists.llvm.org/pipermail/llvm-dev/2021-May/150344.html
https://lists.llvm.org/pipermail/llvm-dev/2021-May/150619.html
It includes updated wording suggested by David Blaikie.
I did not move any information to different sections because that would change the structure of the document: I wanted to keep the information about tools used for reviews in the same section where it was originally located.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D103811
Files:
llvm/docs/CodeReview.rst
Index: llvm/docs/CodeReview.rst
===================================================================
--- llvm/docs/CodeReview.rst
+++ llvm/docs/CodeReview.rst
@@ -78,9 +78,10 @@
What Tools Are Used for Code Review?
------------------------------------
-Code reviews are conducted, in order of preference, on our web-based
-code-review tool (see :doc:`Phabricator`), by email on the relevant project's
-commit mailing list, on the project's development list, or on the bug tracker.
+Pre-commit code reviews are conducted on our web-based code-review tool (see
+:doc:`Phabricator`). Post-commit reviews can be done on Phabricator, by email
+on the relevant project's commit mailing list, on the project's development
+list, or on the bug tracker.
When Is an RFC Required?
------------------------
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103811.350274.patch
Type: text/x-patch
Size: 802 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210607/51e5537e/attachment.bin>
More information about the llvm-commits
mailing list