[PATCH] D103261: [AMDGPU] Increase alignment of LDS globals if necessary before LDS lowering.

[Mahesha S via Phabricator via llvm-commits]

hsmhsm added a comment.

In D103261#2802563 <https://reviews.llvm.org/D103261#2802563>, @JonChesterfield wrote:

> Yes, I see that you agree with the wording you committed. We can't fix it now.
>
>> this patch is harmless and does not cause any potential problems
>
> This patch increases LDS usage. Increasing LDS usage can take us over an occupancy threshold, where the last threshold converts a program that runs to one that doesn't. Using more LDS here also prevents it from being used by promote alloca, where it may have made a bigger performance improvement.
>
> The code change itself is probably OK, my objection is to characterising a transform that ignores user annotation and can improve, degrade, or break programs as 'necessary' or 'proper', and that you stuck with that description even after attention was drawn to it.

As you suggested, and as I agreed to it, let's add a command line switch, make it "on" by default, and let user turn it off, if he/she does not want this transformation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103261/new/

https://reviews.llvm.org/D103261