[PATCH] D102894: [SystemZ] Emit .gnu_attribute for an externally visible vector abi.

Ulrich Weigand via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 7 06:44:54 PDT 2021


uweigand added a comment.

I haven't looked at the code in detail yet, but just a couple of general comments:

- The GNU attribute support should probably just go into the generic ELF target streamer.  This concept is supported in principle on all ELF targets.   (That might also avoid the need for multiple inheritance.)
- If we support the GNU attribute generally in the ELF streamer, then we should also support it generally in the asm streamer (and then also the common asm parser, I guess)
- ASM parser support for .gnu_attribute should support any tag&value just like GAS does.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102894/new/

https://reviews.llvm.org/D102894



More information about the llvm-commits mailing list