[PATCH] D102834: [SLPVectorizer] WIP Implement initial memory versioning (WIP!)

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added a comment.

In D102834#2802402 <https://reviews.llvm.org/D102834#2802402>, @fhahn wrote:

> In D102834#2793483 <https://reviews.llvm.org/D102834#2793483>, @SjoerdMeijer wrote:
>
>> Hi Florian, thanks for putting this up for review and starting the discussion. If you don't mind me asking, how high is this on your todo-list? The reason I am asking is that this well help x264 where we are behind a lot (and it more in general it solves this long outstanding issue that we have). Fixing x264 is high on our list, which is why I put up D102748 <https://reviews.llvm.org/D102748> to start this discussion. If, for example, you don't see time to work on this, we could consider looking at it.
>
> It's fairly high on my todo list, as we have quite a number of of such cases reported by our internal users. But I'm not planning to rush and I think we should also start collecting micro-benchmarks for the missed opportunities, so we can thoroughly evaluate the impact  and do not introduce regressions in the future.

Nice one, excellent. What are your ideas on the micro-benchmarks? Is that something you'll be using internally, or were you e.g. thinking about adding things to the test suite. Just asking because I would be happy to contribute to that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102834/new/

https://reviews.llvm.org/D102834