[PATCH] D93470: [VP] Binary floating-point intrinsics.

[Simon Moll via Phabricator via llvm-commits]

simoll added inline comments.


================
Comment at: llvm/docs/LangRef.rst:18059
+      %t = fadd <4 x float> %a, %b
+      %also.r = select <4 x i1> %mask, <4 x float> %t, <4 x float> undef
+
----------------
majnemer wrote:
> Would it be more general/useful to have the intrinsics take an alternative value just like llvm.masked.load and its passthru operand? You would get identical behavior to your proposal by setting this passthru to undef.
My take is this: if there was a passthru parameter we'd still have to optimize/match the `op+select` into `op_with_passthru`. So, if the simple op+select idiom (that people are already using, btw) suffices to model passthru why add a redundant parameter/code path?

We had this discussion a while back: https://reviews.llvm.org/D57504#1851456






Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93470/new/

https://reviews.llvm.org/D93470