[PATCH] D103421: [Constants] Extend support for scalable-vector splats

Mon Jun 7 04:03:26 PDT 2021

frasercrmck added inline comments.

================
Comment at: llvm/test/Transforms/InstCombine/sub.ll:842
+
+; FIXME: We're not giving this new 'add' a nsw flag as in the fixed-length case
+; above. We need to be able catch the splat with dyn_castNegVal.
----------------
@RKSimon by removing the change to `dyn_castNegVal` I wasn't able to find a good test case for `isNotMinSignedValue` so I just left this as a FIXME here. This is now addressed in D103801 (which can go in after - I similarly wasn't able to find a test case for it without this patch).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103421/new/

https://reviews.llvm.org/D103421