[PATCH] D103699: [AMDGPU] Fix MC tests for v_fmaak_f16 and v_fmamk_f16

[Dmitry Preobrazhensky via Phabricator via llvm-commits]

dp added a comment.

In D103699#2802054 <https://reviews.llvm.org/D103699#2802054>, @foad wrote:

> In D103699#2799700 <https://reviews.llvm.org/D103699#2799700>, @Joe_Nash wrote:
>
>> The tests you changed had 2 byte constants vs the 4 byte ones in the remaining f32 tests. But I don't know if that is significant.
>
> I assumed that the tests with 2 byte literals were originally supposed to be for the f16 instrucction, and someone just forgot to change the opcodes.

It is significant - assembler expects 16 bit literals for 16 bit operands like u16 or f16 - see https://llvm.org/docs/AMDGPUOperandSyntax.html#type-and-size-conversion.
If I remember correctly, HW ignores high 16 bits of literals specified for 16 bit operands.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103699/new/

https://reviews.llvm.org/D103699