[PATCH] D103251: [NFC] Fix semantic discrepancy for MVT::LAST_VALUETYPE

Guillaume Chatelet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 7 03:02:06 PDT 2021


gchatelet marked an inline comment as done.
gchatelet added inline comments.


================
Comment at: llvm/include/llvm/Support/MachineValueType.h:1373
+      return mvt_range(MVT::FIRST_VALUETYPE,
+                       (MVT::SimpleValueType)(MVT::LAST_VALUETYPE + 1));
     }
----------------
courbet wrote:
> Why not `VALUETYPE_SIZE` ?
For consistency with the functions below.
I have a follow up patch that will simplify all these functions so it's simpler if they look the same.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103251/new/

https://reviews.llvm.org/D103251



More information about the llvm-commits mailing list