[PATCH] D103798: [CostModel] Return Invalid cost in getArithmeticCost instead of crashing for scalable vectors.
Sander de Smalen via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Jun 7 02:59:30 PDT 2021
sdesmalen created this revision.
sdesmalen requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
This fixes an issue in BasicTTIImpl.h where it tries to do a
cast<FixedVectorType> on a scalable vector type in order to get the
scalarization cost. Because scalarization of scalable vectors is not
supported, we return Invalid instead.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D103798
Files:
llvm/include/llvm/CodeGen/BasicTTIImpl.h
llvm/test/Analysis/CostModel/AArch64/sve-remainder.ll
Index: llvm/test/Analysis/CostModel/AArch64/sve-remainder.ll
===================================================================
--- /dev/null
+++ llvm/test/Analysis/CostModel/AArch64/sve-remainder.ll
@@ -0,0 +1,61 @@
+; NOTE: Assertions have been autogenerated by utils/update_analyze_test_checks.py
+; RUN: opt -cost-model -analyze -mtriple aarch64-linux-gnu -mattr=+sve < %s | FileCheck %s
+
+define void @test_urem_srem_expand() {
+; CHECK-LABEL: 'test_urem_srem_expand'
+; CHECK-NEXT: Cost Model: Invalid cost for instruction: %legal_type_urem_0 = urem <vscale x 16 x i8> undef, undef
+; CHECK-NEXT: Cost Model: Invalid cost for instruction: %legal_type_urem_1 = urem <vscale x 8 x i16> undef, undef
+; CHECK-NEXT: Cost Model: Invalid cost for instruction: %legal_type_urem_2 = urem <vscale x 4 x i32> undef, undef
+; CHECK-NEXT: Cost Model: Invalid cost for instruction: %legal_type_urem_3 = urem <vscale x 2 x i64> undef, undef
+; CHECK-NEXT: Cost Model: Invalid cost for instruction: %legal_type_srem_0 = srem <vscale x 16 x i8> undef, undef
+; CHECK-NEXT: Cost Model: Invalid cost for instruction: %legal_type_srem_1 = srem <vscale x 8 x i16> undef, undef
+; CHECK-NEXT: Cost Model: Invalid cost for instruction: %legal_type_srem_2 = srem <vscale x 4 x i32> undef, undef
+; CHECK-NEXT: Cost Model: Invalid cost for instruction: %legal_type_srem_3 = srem <vscale x 2 x i64> undef, undef
+; CHECK-NEXT: Cost Model: Invalid cost for instruction: %split_type_urem_0 = urem <vscale x 32 x i8> undef, undef
+; CHECK-NEXT: Cost Model: Invalid cost for instruction: %split_type_urem_1 = urem <vscale x 16 x i16> undef, undef
+; CHECK-NEXT: Cost Model: Invalid cost for instruction: %split_type_urem_2 = urem <vscale x 8 x i32> undef, undef
+; CHECK-NEXT: Cost Model: Invalid cost for instruction: %split_type_urem_3 = urem <vscale x 4 x i64> undef, undef
+; CHECK-NEXT: Cost Model: Invalid cost for instruction: %split_type_srem_0 = srem <vscale x 32 x i8> undef, undef
+; CHECK-NEXT: Cost Model: Invalid cost for instruction: %split_type_srem_1 = srem <vscale x 16 x i16> undef, undef
+; CHECK-NEXT: Cost Model: Invalid cost for instruction: %split_type_srem_2 = srem <vscale x 8 x i32> undef, undef
+; CHECK-NEXT: Cost Model: Invalid cost for instruction: %split_type_srem_3 = srem <vscale x 4 x i64> undef, undef
+; CHECK-NEXT: Cost Model: Invalid cost for instruction: %widen_type_urem_0 = urem <vscale x 31 x i8> undef, undef
+; CHECK-NEXT: Cost Model: Invalid cost for instruction: %widen_type_urem_1 = urem <vscale x 15 x i16> undef, undef
+; CHECK-NEXT: Cost Model: Invalid cost for instruction: %widen_type_urem_2 = urem <vscale x 7 x i32> undef, undef
+; CHECK-NEXT: Cost Model: Invalid cost for instruction: %widen_type_urem_3 = urem <vscale x 3 x i64> undef, undef
+; CHECK-NEXT: Cost Model: Invalid cost for instruction: %widen_type_srem_0 = srem <vscale x 31 x i8> undef, undef
+; CHECK-NEXT: Cost Model: Invalid cost for instruction: %widen_type_srem_1 = srem <vscale x 15 x i16> undef, undef
+; CHECK-NEXT: Cost Model: Invalid cost for instruction: %widen_type_srem_2 = srem <vscale x 7 x i32> undef, undef
+; CHECK-NEXT: Cost Model: Invalid cost for instruction: %widen_type_srem_3 = srem <vscale x 3 x i64> undef, undef
+; CHECK-NEXT: Cost Model: Found an estimated cost of 0 for instruction: ret void
+;
+entry:
+ %legal_type_urem_0 = urem <vscale x 16 x i8> undef, undef
+ %legal_type_urem_1 = urem <vscale x 8 x i16> undef, undef
+ %legal_type_urem_2 = urem <vscale x 4 x i32> undef, undef
+ %legal_type_urem_3 = urem <vscale x 2 x i64> undef, undef
+ %legal_type_srem_0 = srem <vscale x 16 x i8> undef, undef
+ %legal_type_srem_1 = srem <vscale x 8 x i16> undef, undef
+ %legal_type_srem_2 = srem <vscale x 4 x i32> undef, undef
+ %legal_type_srem_3 = srem <vscale x 2 x i64> undef, undef
+
+ %split_type_urem_0 = urem <vscale x 32 x i8> undef, undef
+ %split_type_urem_1 = urem <vscale x 16 x i16> undef, undef
+ %split_type_urem_2 = urem <vscale x 8 x i32> undef, undef
+ %split_type_urem_3 = urem <vscale x 4 x i64> undef, undef
+ %split_type_srem_0 = srem <vscale x 32 x i8> undef, undef
+ %split_type_srem_1 = srem <vscale x 16 x i16> undef, undef
+ %split_type_srem_2 = srem <vscale x 8 x i32> undef, undef
+ %split_type_srem_3 = srem <vscale x 4 x i64> undef, undef
+
+ %widen_type_urem_0 = urem <vscale x 31 x i8> undef, undef
+ %widen_type_urem_1 = urem <vscale x 15 x i16> undef, undef
+ %widen_type_urem_2 = urem <vscale x 7 x i32> undef, undef
+ %widen_type_urem_3 = urem <vscale x 3 x i64> undef, undef
+ %widen_type_srem_0 = srem <vscale x 31 x i8> undef, undef
+ %widen_type_srem_1 = srem <vscale x 15 x i16> undef, undef
+ %widen_type_srem_2 = srem <vscale x 7 x i32> undef, undef
+ %widen_type_srem_3 = srem <vscale x 3 x i64> undef, undef
+
+ ret void
+}
Index: llvm/include/llvm/CodeGen/BasicTTIImpl.h
===================================================================
--- llvm/include/llvm/CodeGen/BasicTTIImpl.h
+++ llvm/include/llvm/CodeGen/BasicTTIImpl.h
@@ -776,18 +776,22 @@
return LT.first * 2 * OpCost;
}
+ // We cannot scalarize scalable vectors, so return Invalid.
+ if (isa<ScalableVectorType>(Ty))
+ return InstructionCost::getInvalid();
+
// Else, assume that we need to scalarize this op.
// TODO: If one of the types get legalized by splitting, handle this
// similarly to what getCastInstrCost() does.
- if (auto *VTy = dyn_cast<VectorType>(Ty)) {
- unsigned Num = cast<FixedVectorType>(VTy)->getNumElements();
+ if (auto *VTy = dyn_cast<FixedVectorType>(Ty)) {
InstructionCost Cost = thisT()->getArithmeticInstrCost(
Opcode, VTy->getScalarType(), CostKind, Opd1Info, Opd2Info,
Opd1PropInfo, Opd2PropInfo, Args, CxtI);
// Return the cost of multiple scalar invocation plus the cost of
// inserting and extracting the values.
SmallVector<Type *> Tys(Args.size(), Ty);
- return getScalarizationOverhead(VTy, Args, Tys) + Num * Cost;
+ return getScalarizationOverhead(VTy, Args, Tys) +
+ VTy->getNumElements() * Cost;
}
// We don't know anything about this scalar instruction.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103798.350217.patch
Type: text/x-patch
Size: 6218 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210607/3db46984/attachment.bin>
More information about the llvm-commits
mailing list