[PATCH] D102296: [ELF] getRelocatedSection: remove the check for ET_REL object file

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 7 02:38:11 PDT 2021


jhenderson accepted this revision.
jhenderson added a comment.

LGTM too. I've got a lot else on my plate, so if @dblaikie or @MaskRay are able to land this, that's preferable. Otherwise, I'll try to do so in the next couple of days.

Maybe it's worth adding a comment to the `getRelocatedSection` declaration to say that it returns the section the input relocations patch, highlighting that that section may or may not have already had their relocations applied.

I think moving the behaviour of "should I apply relocations" to a different place makes sense to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102296/new/

https://reviews.llvm.org/D102296



More information about the llvm-commits mailing list