[PATCH] D103684: [AMDGPU] Stop using LegacyLegalizerInfo. NFCI.

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 7 01:48:39 PDT 2021


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:505
+  // s1 for VCC branches, s32 for SCC branches.
+  getActionDefinitionsBuilder(G_BRCOND).legalFor({S1, S32});
 
----------------
dsanders wrote:
> I'm not 100% sure off-hand if this one had any implicit clampScalar-like rules in the legacy info. I can believe that G_BRCOND only ever forms with s1/s32 though.
I admit that I don't know anything about implicit clamping in the legacy legalizer. But at least this patch passed all our tests.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103684/new/

https://reviews.llvm.org/D103684



More information about the llvm-commits mailing list