[PATCH] D103655: [AMDGPU] Handle constant LDS uses from different kernels

Mahesha S via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 6 08:23:10 PDT 2021


hsmhsm accepted this revision.
hsmhsm added a comment.
This revision is now accepted and ready to land.

LGTM except for the minor comment below,



================
Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPULDSUtils.cpp:36
+                                SetVector<Instruction *> &InstUsers) {
+  SmallVector<User *> Stack({U});
+
----------------
Not sure. what is the reall difference between SmallVector<User *> Stack({U}); and SmallVector<User *> Stack{U};


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103655/new/

https://reviews.llvm.org/D103655



More information about the llvm-commits mailing list