[PATCH] D103655: [AMDGPU] Handle constant LDS uses from different kernels

Fri Jun 4 02:20:21 PDT 2021

hsmhsm added a comment.

In D103655#2797744 <https://reviews.llvm.org/D103655#2797744>, @rampitec wrote:

> @hsmhsm It depends on the convertConstantExprsToInstructions() you have implemented in the D103225 <https://reviews.llvm.org/D103225>. I would appreciate if you extract the helper into a separate review. Kudos for the helper BTW.

Pushed new patch at https://reviews.llvm.org/D103661

In D103655#2797809 <https://reviews.llvm.org/D103655#2797809>, @rampitec wrote:

> I think from this we are just one step from removing module lds except for potentially indirect functions. Everything else can be moved into kernel lds structure.
>
> We do have a problem with excessive use of lds in rocBLAS because of the module lds already, so technically we have a regression with it. There is a w/a but it is better be solved sooner rather than later.

I am not sure, if we can completely eliminate module lds. My understanding is that it is still required to handle within non-kernel function used LDS.  But, instead of directly dealing with LDS, it should deal with pointers, hence the patch https://reviews.llvm.org/D103225.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103655/new/

https://reviews.llvm.org/D103655