[PATCH] D103756: [DAG] Allow isNullOrNullSplat to see truncated zeroes

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 6 23:55:41 PDT 2021


dmgreen added a comment.

In D103756#2800940 <https://reviews.llvm.org/D103756#2800940>, @RKSimon wrote:

>> Whilst I'm here also add a call to peekThroughBitcasts as bitcast Zero is still Zero, and removed a related TODO comment from isOneOrOneSplat as the bitcast of 1 isn't always still 1.
>
> Is this necessary for any of the test changes? I just wonder whether we should add this separately.

Sure, I can remove it from here, it won't effect any of the test cases. I believe we will already turn bitcast(buildvector(0's)) to buildvector(0's) already.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103756/new/

https://reviews.llvm.org/D103756



More information about the llvm-commits mailing list