[PATCH] D102234: [SimpleLoopBoundSplit] Split Bound of Loop which has conditional branch with IV

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev accepted this revision.
mkazantsev added a comment.
This revision is now accepted and ready to land.

My fuzzer didn't reveal any new failures, so there is a chance it's working as expected. :) LGTM with some nits.



================
Comment at: llvm/lib/Transforms/Scalar/LoopBoundSplit.cpp:32
+
+struct ConditionInfo {
+  /// Branch instruction with this condition
----------------
Please lock it in anonymous namespace (see how it's done e.g. in InstSimplifypass.cpp), https://llvm.org/docs/CodingStandards.html#anonymous-namespaces




================
Comment at: llvm/lib/Transforms/Scalar/LoopBoundSplit.cpp:423
+  Function &F = *L.getHeader()->getParent();
+  (void)F;
+
----------------
Please delete this.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102234/new/

https://reviews.llvm.org/D102234