[PATCH] D103261: [AMDGPU] Increase alignment of LDS globals if necessary before LDS lowering.

Mahesha S via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 6 23:45:17 PDT 2021


hsmhsm added a comment.

Hi @JonChesterfield

We believe, this patch is harmless and does not cause any potential problems. As I already mentioned in my previous comment, the un-optimal padding memory is largely due to sorting logic (we should use size as primary key instead of alignment). Morever, we think, this patch is very important in our attempt to solve perf issues due to unliagned access of LDS. So, I am going to submit this patch since it is accepted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103261/new/

https://reviews.llvm.org/D103261



More information about the llvm-commits mailing list