[PATCH] D103751: [Polly][Isl] Removing nullptr constructor from C++ bindings. NFC.

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 6 21:48:58 PDT 2021


Meinersbur accepted this revision.
Meinersbur added a comment.
This revision is now accepted and ready to land.

LGTM.

Could you mention in the commit message/summary that the goal/motivation is to make the isl-noexceptions.h converge towards the official bindings?



================
Comment at: polly/lib/Transform/ScheduleOptimizer.cpp:1702
 
-  ~IslScheduleOptimizerWrapperPass() override { releaseMemory(); }
-
----------------
This might have been there to ensure the order in which the objects are freed. `LastSchedule` must be free'd before `IslCtx`.

However, destruction order is defined to be in reverse of the field declaration order, so indeed what we want.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103751/new/

https://reviews.llvm.org/D103751



More information about the llvm-commits mailing list