[PATCH] D102574: [InstCombine] Missed optimization for pow(x, y) * pow(x, z) with fast-math

[Daniil Seredkin via Phabricator via llvm-commits]

vdsered added inline comments.


================
Comment at: llvm/test/Transforms/InstCombine/fmul-pow.ll:105
 ; CHECK-LABEL: @pow_ab_reassoc_extra_use(
-; CHECK-NEXT:    [[TMP1:%.*]] = call double @llvm.pow.f64(double [[A:%.*]], double [[B:%.*]])
-; CHECK-NEXT:    [[MUL:%.*]] = fmul reassoc double [[TMP1]], [[TMP1]]
-; CHECK-NEXT:    call void @use(double [[TMP1]])
+; CHECK-NEXT:    [[POW:%.*]] = call double @llvm.pow.f64(double [[A:%.*]], double [[B:%.*]])
+; CHECK-NEXT:    [[MUL:%.*]] = fmul reassoc double [[POW]], [[POW]]
----------------
spatel wrote:
> Do you know why you are getting this (and similar) test changes? They are cosmetic (value names differ), but I don't see this when testing locally.
I have seen recently how update_test_checks warned about using tmps in tests so I thought of renaming. It doesn't say anything for these tests however... Updated the patch to remove the naming diff and see the actual changes in output for tests


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102574/new/

https://reviews.llvm.org/D102574