[PATCH] D99481: [InstCombine] Fix miscompile on GEP+load to icmp fold (PR45210)
    Eli Friedman via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Sun Jun  6 15:57:49 PDT 2021
    
    
  
efriedma added a comment.
I don't think the revised change really solves the problem.  The reason you end up with dead instructions is the "return nullptr;" at the end of the function, around line 402.  The new code doesn't seem related to that.  If we narrow the cases where the generate the lshr+and, the infloop might trigger less frequently, but it doesn't really solve the general problem.
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99481/new/
https://reviews.llvm.org/D99481
    
    
More information about the llvm-commits
mailing list