[PATCH] D103539: WIP: try to repair RISCV handling of paired relocations

[Simon Cook via Phabricator via llvm-commits]

simoncook added inline comments.


================
Comment at: llvm/test/CodeGen/RISCV/fixups-relax-diff.ll:19
   call void asm sideeffect "a:\0Ab:\0A.dword b-a", ""()
   ret i32 0
 }
----------------
compnerd wrote:
> jrtc27 wrote:
> > There's no longer a RUN line for this... also this test makes no sense in the first place, it's trying to use 64-bit relocations on RV32. That should just be an error.
> I didn't even notice that the relocation types are just flat out wrong.  That seems like a separate issue.
> 
> I wanted to keep the now dead check to do a last round of verification of the changes, at which point it should be removed.
The relocations are 64-bit because of the size of `.dword`, I don't think this is an error?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103539/new/

https://reviews.llvm.org/D103539