[llvm] b69e16b - X86MachObjectWriter.cpp - silence null deference warnings. NFCI.

[Simon Pilgrim via llvm-commits]

Author: Simon Pilgrim
Date: 2021-06-06T15:33:47+01:00
New Revision: b69e16b5cce6987dd9da3570c1b97e4b7e437d85

URL: https://github.com/llvm/llvm-project/commit/b69e16b5cce6987dd9da3570c1b97e4b7e437d85
DIFF: https://github.com/llvm/llvm-project/commit/b69e16b5cce6987dd9da3570c1b97e4b7e437d85.diff

LOG: X86MachObjectWriter.cpp - silence null deference warnings. NFCI.

The MCSymbol data should always be present for non-absolute sections so assert that it is to silence static analysis warnings.

Added: 
    

Modified: 
    llvm/lib/Target/X86/MCTargetDesc/X86MachObjectWriter.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/X86/MCTargetDesc/X86MachObjectWriter.cpp b/llvm/lib/Target/X86/MCTargetDesc/X86MachObjectWriter.cpp
index b98e58d653db5..dff9b315f3cde 100644
--- a/llvm/lib/Target/X86/MCTargetDesc/X86MachObjectWriter.cpp
+++ b/llvm/lib/Target/X86/MCTargetDesc/X86MachObjectWriter.cpp
@@ -537,6 +537,7 @@ void X86MachObjectWriter::RecordX86Relocation(MachObjectWriter *Writer,
   uint32_t Offset = Target.getConstant();
   if (IsPCRel)
     Offset += 1 << Log2Size;
+
   // Try to record the scattered relocation if needed. Fall back to non
   // scattered if necessary (see comments in recordScatteredRelocation()
   // for details).
@@ -558,6 +559,8 @@ void X86MachObjectWriter::RecordX86Relocation(MachObjectWriter *Writer,
     // find a case where they are actually emitted.
     Type = MachO::GENERIC_RELOC_VANILLA;
   } else {
+    assert(A && "Unknown symbol data");
+
     // Resolve constant variables.
     if (A->isVariable()) {
       int64_t Res;