[llvm] 76a1be0 - AssumeBundleQueries.cpp - don't dereference a dyn_cast<> result. NFCI.

[Simon Pilgrim via llvm-commits]

Author: Simon Pilgrim
Date: 2021-06-06T15:25:03+01:00
New Revision: 76a1be05fa00638532bfda02839f1847ab15ede7

URL: https://github.com/llvm/llvm-project/commit/76a1be05fa00638532bfda02839f1847ab15ede7
DIFF: https://github.com/llvm/llvm-project/commit/76a1be05fa00638532bfda02839f1847ab15ede7.diff

LOG: AssumeBundleQueries.cpp - don't dereference a dyn_cast<> result. NFCI.

Use cast<> instead which will assert that the cast is correct and not just return null - the match() should have already failed if the cast isn't valid anyhow.

Fixes static analysis warning.

Added: 
    

Modified: 
    llvm/lib/Analysis/AssumeBundleQueries.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Analysis/AssumeBundleQueries.cpp b/llvm/lib/Analysis/AssumeBundleQueries.cpp
index 11f3e0317814..519d27aa3fb7 100644
--- a/llvm/lib/Analysis/AssumeBundleQueries.cpp
+++ b/llvm/lib/Analysis/AssumeBundleQueries.cpp
@@ -130,10 +130,10 @@ bool llvm::isAssumeWithEmptyBundle(AssumeInst &Assume) {
 }
 
 static CallInst::BundleOpInfo *getBundleFromUse(const Use *U) {
-  auto *Intr = dyn_cast<IntrinsicInst>(U->getUser());
   if (!match(U->getUser(),
              m_Intrinsic<Intrinsic::assume>(m_Unless(m_Specific(U->get())))))
     return nullptr;
+  auto *Intr = cast<IntrinsicInst>(U->getUser());
   return &Intr->getBundleOpInfoForOperand(U->getOperandNo());
 }