[PATCH] D103759: [TargetLowering] Use IRBuilderBase instead of IRBuilder<> (NFC)

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 5 14:15:44 PDT 2021


RKSimon added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:43
 #include "llvm/IR/Function.h"
 #include "llvm/IR/IRBuilder.h"
 #include "llvm/IR/InlineAsm.h"
----------------
nikic wrote:
> RKSimon wrote:
> > I don't suppose this will let us drop the IRBuilder.h include and just use forward declarations? TargetLowering.h is a pretty heavy include and anything to reduce it would be very useful.
> Yes, that's exactly the goal here :) I just wanted to separate the API changing part of the change first. Otherwise this should be matter of moving a couple default implementations out of line and lots of include fixup in other files.
Sorry I obviously didn't fully read the summary :) 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103759/new/

https://reviews.llvm.org/D103759



More information about the llvm-commits mailing list