[PATCH] D103742: [RISCV] Support vector maximum and minimum for RVP
Craig Topper via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sat Jun 5 12:46:18 PDT 2021
craig.topper added inline comments.
================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:842
setCondCodeAction(CC, VT, Expand);
+ setOperationAction(ISD::VSELECT, VT, Legal);
----------------
What about cases where it isn't min/max? You'll have an unselectable vselect.
Why aren't not make ISD::SMAX and ISD::SMIN legal and match those?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103742/new/
https://reviews.llvm.org/D103742
More information about the llvm-commits
mailing list