[PATCH] D101819: [DRAFT][M68k][GloballSel] Adding initial GlobalISel infrastructure

[Sushma Unnibhavi via Phabricator via llvm-commits]

sushmaunnibhavi added inline comments.


================
Comment at: llvm/lib/CodeGen/GlobalISel/IRTranslator.cpp:3131
+    // TODO : removing reportTranslationError until big endian is supported
+    // reportTranslationError(*MF, *TPC, *ORE, R);
   }
----------------
qcolombet wrote:
> Instead of purely removing it, turn that into a warning.
@qcolombet , @aemerson 
Is it right if I do this instead?

```
if (Triple(MF->getTarget().getTargetTriple()).getArch() != Triple::m68k) {
      reportTranslationError(*MF, *TPC, *ORE, R);
    }
```

This would not call reportTranslationError only for m68k but would not affect any other targets. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101819/new/

https://reviews.llvm.org/D101819