[PATCH] D103505: [lld][MachO] Add first bits to support special symbols

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added inline comments.


================
Comment at: lld/MachO/InputFiles.cpp:978
+  std::tie(endVersion, symbolName) = name.split('$');
+  symbolName = symbolName.drop_back(1 /* $ */);
+  // TODO: ld64 contains some logic for non-empty symbolName as well.
----------------
thakis wrote:
> I'm guessing the `$` is there as an extension point so that additional stuff can be added later if necessary. So maybe
> 
>     std::tie(symbolName, rest) = name.split('$');
> 
> might be better, in case more stuff is in fact added later?
sure, sounds good


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103505/new/

https://reviews.llvm.org/D103505