[compiler-rt] 9ff982d - [NFC][scudo] Fix sign-compare warning in test

Vitaly Buka via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 4 19:34:29 PDT 2021


Author: Vitaly Buka
Date: 2021-06-04T19:33:42-07:00
New Revision: 9ff982dbbdd4d0f851e0b32440e13ac92635ac6f

URL: https://github.com/llvm/llvm-project/commit/9ff982dbbdd4d0f851e0b32440e13ac92635ac6f
DIFF: https://github.com/llvm/llvm-project/commit/9ff982dbbdd4d0f851e0b32440e13ac92635ac6f.diff

LOG: [NFC][scudo] Fix sign-compare warning in test

Added: 
    

Modified: 
    compiler-rt/lib/scudo/standalone/tests/memtag_test.cpp
    compiler-rt/lib/scudo/standalone/tests/strings_test.cpp

Removed: 
    


################################################################################
diff  --git a/compiler-rt/lib/scudo/standalone/tests/memtag_test.cpp b/compiler-rt/lib/scudo/standalone/tests/memtag_test.cpp
index 8726fc2e1710..50ba0fc82ced 100644
--- a/compiler-rt/lib/scudo/standalone/tests/memtag_test.cpp
+++ b/compiler-rt/lib/scudo/standalone/tests/memtag_test.cpp
@@ -109,7 +109,7 @@ TEST_F(MemtagTest, SelectRandomTag) {
     uptr Tags = 0;
     for (uptr I = 0; I < 100000; ++I)
       Tags = Tags | (1u << extractTag(selectRandomTag(Ptr, 0)));
-    EXPECT_EQ(0xfffe, Tags);
+    EXPECT_EQ(0xfffeull, Tags);
   }
 }
 

diff  --git a/compiler-rt/lib/scudo/standalone/tests/strings_test.cpp b/compiler-rt/lib/scudo/standalone/tests/strings_test.cpp
index 298977a14c80..6d7e78a816ac 100644
--- a/compiler-rt/lib/scudo/standalone/tests/strings_test.cpp
+++ b/compiler-rt/lib/scudo/standalone/tests/strings_test.cpp
@@ -14,7 +14,7 @@
 
 TEST(ScudoStringsTest, Constructor) {
   scudo::ScopedString Str;
-  EXPECT_EQ(0, Str.length());
+  EXPECT_EQ(0ul, Str.length());
   EXPECT_EQ('\0', *Str.data());
 }
 
@@ -38,7 +38,7 @@ TEST(ScudoStringsTest, Clear) {
   scudo::ScopedString Str;
   Str.append("123");
   Str.clear();
-  EXPECT_EQ(0, Str.length());
+  EXPECT_EQ(0ul, Str.length());
   EXPECT_EQ('\0', *Str.data());
 }
 
@@ -47,7 +47,7 @@ TEST(ScudoStringsTest, ClearLarge) {
   for (int i = 0; i < 10000; ++i)
     Str.append("123");
   Str.clear();
-  EXPECT_EQ(0, Str.length());
+  EXPECT_EQ(0ul, Str.length());
   EXPECT_EQ('\0', *Str.data());
 }
 


        


More information about the llvm-commits mailing list