[PATCH] D102296: [ELF] getRelocatedSection: remove the check for ET_REL object file

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 4 14:57:07 PDT 2021


MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/unittests/Object/ELFObjectFileTest.cpp:612
+    Info:  .text
+Symbols:
+  - Name:    .text
----------------
Delete Symbols. It is not used. STT_SECTION is not needed if not used as relocation targets (https://sourceware.org/bugzilla/show_bug.cgi?id=27109)


================
Comment at: llvm/unittests/Object/ELFObjectFileTest.cpp:646
+
+  // Check ET_EXEC file.
+  SmallString<128> ExecFileYamlString(HeaderString);
----------------
Add a comment that this is for `ld --emit-relocs`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102296/new/

https://reviews.llvm.org/D102296



More information about the llvm-commits mailing list