[PATCH] D103661: [IR] Add utility to convert constant expression operands (of an instruction) to instructions.

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 4 14:47:22 PDT 2021


rampitec added inline comments.


================
Comment at: llvm/include/llvm/IR/ReplaceConstant.h:40
+                                        SmallPtrSetImpl<Value *> &Operands,
+                                        SmallPtrSetImpl<Instruction *> &Insts);
+
----------------
I would make Insts operand optional pointer. For instance I do not need it in D103655.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103661/new/

https://reviews.llvm.org/D103661



More information about the llvm-commits mailing list