[PATCH] D103656: [ScalarEvolution] Ensure backedge-taken counts are not pointers.

[Philip Reames via Phabricator via llvm-commits]

reames requested changes to this revision.
reames added a comment.
This revision now requires changes to proceed.

The implementation and description of this patch seem badly out of sync.

Modifying the loop exit computation to always return an integer type *might* be reasonable.  As has been raised already, there are concern with non-integral pointers, or cases where we don't *know* the size of a pointer, but those might be addressable.  I have concerns, but they're potentially addressable concerns.

However, that doesn't seem to be what the implementation of this patch actually does?  Having isKnownPredicate simply return false for a pointer argument which can't be cast is definitely not okay.  Did you maybe upload the wrong diff?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103656/new/

https://reviews.llvm.org/D103656