[PATCH] D103714: [flang] Check for undefined derived types

Pete Steinfeld via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 4 14:16:23 PDT 2021


PeteSteinfeld added inline comments.


================
Comment at: flang/include/flang/Semantics/symbol.h:295
   bool isForwardReferenced_{false};
+  bool isDefined_{false};
   friend llvm::raw_ostream &operator<<(
----------------
klausler wrote:
> Is `isDefined_` needed?  If a type symbol is created due to a forward reference, `isForwardReferenced_` will be set; maybe you can clear it when/if the type is defined, and then just test that flag later.
Good idea.  New update coming ...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103714/new/

https://reviews.llvm.org/D103714



More information about the llvm-commits mailing list