[PATCH] D103304: Update and improve compiler-rt tests for -mllvm -asan_use_after_return=(never|[runtime]|always).

Fri Jun 4 12:58:42 PDT 2021

mstorsjo added a comment.

In D103304#2799816 <https://reviews.llvm.org/D103304#2799816>, @kda wrote:

> In D103304#2798480 <https://reviews.llvm.org/D103304#2798480>, @mstorsjo wrote:
>
>> FWIW, this patch also broke building for windows. Weak symbols overall is a tricky area on windows, and I don't think this particular usage (the asan lib having a weak undefined symbol, which the executable may or may not proivide) works with windows DLLs at all.
>
> @mstorsjo Is there a short-term work around?
> FYI: I do plan to follow with a late-initialization solution.

I'm not well versed in the asan internals to know all the tricks that are used so far, but if this mechanism is a new thing and we've done without it so far and seems hard to do, can we just ifdef it out on windows and keep doing things like they were before there?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103304/new/

https://reviews.llvm.org/D103304