[PATCH] D103431: [AMDGPU] Fix missing lowering of LDS used in global scope.

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 4 11:58:17 PDT 2021


rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/Utils/AMDGPULDSUtils.cpp:71
+  // We are not interested in kernel LDS lowering for module LDS itself.
+  if (F && GV.getName() == "llvm.amdgcn.module.lds") {
+    return false;
----------------
foad wrote:
> rampitec wrote:
> > .equals(). I don't think == does what you want.
> No, `==` should be fine. Both `==` and `equals` take two StringRefs and do a full string comparison on them.
I do not see StringRef::operator==() in the documentation?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103431/new/

https://reviews.llvm.org/D103431



More information about the llvm-commits mailing list