[PATCH] D103546: Added ELFObjectFileBase::checkMagic() for checking ELF magic word.

Vyacheslav Zakharin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 4 11:40:59 PDT 2021


vzakhari added a comment.

In D103546#2799569 <https://reviews.llvm.org/D103546#2799569>, @MaskRay wrote:

> We have `lib/BinaryFormat/Magic.cpp`. Do we need the ELF specific API?

Thanks!  I was not aware of this code.  How about adding something like `static inline is_any_elf(file_magic)` method in `Magic.h`?  If you agree, then I will abandon this change-set and add the new method in D103545 <https://reviews.llvm.org/D103545>.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103546/new/

https://reviews.llvm.org/D103546



More information about the llvm-commits mailing list