[PATCH] D101819: [DRAFT][M68k][GloballSel] Adding initial GlobalISel infrastructure

[Amara Emerson via Phabricator via llvm-commits]

aemerson added a comment.

In D101819#2798940 <https://reviews.llvm.org/D101819#2798940>, @sushmaunnibhavi wrote:

> In D101819#2780892 <https://reviews.llvm.org/D101819#2780892>, @qcolombet wrote:
>
>> Hi,
>>
>>> LLVM ERROR: unable to translate in big endian mode (in function: f)
>>
>> You'll need to turn that into a warning, otherwise effectively, none of your GISel changes will be testable (as in running the generated code on an actual target) until the support is complete, which is not a realistic constraint to have when bringing up a new GISel backend.
>>
>> Cheers,
>> -Quentin
>
> Hi @qcolombet ,
> When I do a git grep with that error message, I find that it comes from IRTranslator.cpp file and in the runOnMachineFunction() function where it checks for big endian and throws a reportTranslationError() which is where that error comes from. By removing the reportTranslationError() temporarily in order to test my implementation, that would cause errors in other targets.  Can you please suggest me any other way to solve this issue?
>
> Thanks,
> Sushma

You can add a hook to TargetLoweringInfo so that only targets which want to use big-endian in GlobalISel can enable it (just M68k for now). Then check this hook, if it false then do the current fallback code.



================
Comment at: llvm/CMakeLists.txt:315
   XCore
+  M68k
   )
----------------
sushmaunnibhavi wrote:
> RKSimon wrote:
> > M68k is an experimental target - it should NOT be added to any default target list
> I will be temporarily keeping this in default targets since if I don't then when I submit the patch it will show "M68kGenRegisterBank.inc file not found" error. Maybe the buildbot does not check M68k backend with experimental_target_build flag. So I am keeping M68k in default targets temporarily.
I'm not familiar with this issue, but it sounds like a problem with the build system/cmake config. Either way, even adding this temporarily to the default targets can't be done if you want to have this committed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101819/new/

https://reviews.llvm.org/D101819