[PATCH] D103458: [SLP]Improve gathering of scalar elements.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

a couple of minors - does anyone else have any comments?



================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:4833
+    if (auto *Inst = dyn_cast<Instruction>(VL[I]))
+      if ((CheckPredecessor(Inst->getParent(), Builder.GetInsertBlock()) ||
+           getTreeEntry(Inst) || (L && (L->contains(Inst)))) &&
----------------
unnecessary () ?


================
Comment at: llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp:4938
+        ShuffleVectorInst::isIdentityMask(Mask))
       return V;
     return Builder.CreateShuffleVector(V, Mask, "shuffle");
----------------
Pull out repeated cast<FixedVectorType>(V->getType())->getNumElements()?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103458/new/

https://reviews.llvm.org/D103458