[PATCH] D103372: [InstrProfiling] If no value profiling, make data variable private and (for Windows) use one comdat

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 4 07:00:58 PDT 2021


thakis added a comment.

This breaks instrprof-dynamic-one-shared.test instrprof-dynamic-two-shared.test in check-profile on macOS. I reverted this for now in e9a9c850989e2392b7f16dea2449312c15bd0240 <https://reviews.llvm.org/rGe9a9c850989e2392b7f16dea2449312c15bd0240>

https://bugs.chromium.org/p/chromium/issues/detail?id=1216425 has detailed output, but it repros locally without problems.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103372/new/

https://reviews.llvm.org/D103372



More information about the llvm-commits mailing list