[PATCH] D102515: [CostModel] Return an invalid cost for memory ops with unsupported types

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 4 06:42:52 PDT 2021


sdesmalen added a comment.

Just one final request about one of the tests, but otherwise the patch looks good to me.



================
Comment at: llvm/unittests/CodeGen/AArch64SelectionDAGTest.cpp:576
 
-TEST_F(AArch64SelectionDAGTest, getTypeConversion_NoScalarizeEVT_nxv1f128) {
-  EVT FromVT = EVT::getVectorVT(Context, MVT::f128, 1, true);
----------------
Instead of removing the test, can you instead check that the TypeAction is ScalarizeScalableVector?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102515/new/

https://reviews.llvm.org/D102515



More information about the llvm-commits mailing list