[PATCH] D102515: [CostModel] Return an invalid cost for memory ops with unsupported types

Kerry McLaughlin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 4 05:59:29 PDT 2021


kmclaughlin updated this revision to Diff 349841.
kmclaughlin marked 2 inline comments as done.
kmclaughlin edited the summary of this revision.
kmclaughlin added a subscriber: spatel.
kmclaughlin added a comment.

- Changed getTypeConversion back to return an invalid cost for TypeScalarizeScalableVector.
- Added tests for loads of nxv1i128, nxv2i128, nxv1f128 & nxv2f128 to sve-illegal-types.ll & grouped the instructions into fewer functions.
- Moved a failing test from test/Transforms/VectorCombine/X86/extract-cmp-binop.ll. This test uses scalable vectors and will fail in `X86TTIImpl::getVectorInstrCost` with the changes in this patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102515/new/

https://reviews.llvm.org/D102515

Files:
  llvm/lib/CodeGen/TargetLoweringBase.cpp
  llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp
  llvm/test/Analysis/CostModel/AArch64/sve-illegal-types.ll
  llvm/test/Transforms/LoopVectorize/AArch64/scalable-vf-hint.ll
  llvm/test/Transforms/VectorCombine/AArch64/extract-cmp-binop.ll
  llvm/test/Transforms/VectorCombine/X86/extract-cmp-binop.ll
  llvm/unittests/CodeGen/AArch64SelectionDAGTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D102515.349841.patch
Type: text/x-patch
Size: 12394 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210604/947e9e61/attachment.bin>


More information about the llvm-commits mailing list