[PATCH] D86813: [DebugInstrRef][2/3] Track PHI values through register coalescing

Fri Jun 4 03:45:18 PDT 2021

djtodoro added a comment.

In D86813#2797746 <https://reviews.llvm.org/D86813#2797746>, @aprantl wrote:

> In D86813#2793958 <https://reviews.llvm.org/D86813#2793958>, @jmorse wrote:
>
>>> lgtm
>>
>> Cheers,
>>
>>> @jmorse @aprantl Sorry for the divergence, but regarding this tests reduction in terms of DI Metadata -- do you think that we can automate this process? I've written a small write-up/proposal for a utility for that purpose: https://github.com/djolertrk/llvm-metadataburn -- please let me know what you think.
>>
>> Highly relevant to my interests, this'd save 5-10 minutes frequently fiddling with metadata, and it eases newcomers preparation / revision of patches. Yes please!
>
> Yes! Bugpoint can already reduce metadata — I'm wondering if this could maybe a mode of bugpoint in the future?

I guess it can be done in both bugpoint and llvm-reduce -- I am just not sure that by doing this tricks we are preserving "the code equivalence" (since we are removing right metadata) and that it is desirable in these tools.

In D86813#2798472 <https://reviews.llvm.org/D86813#2798472>, @jmorse wrote:

> In D86813#2797746 <https://reviews.llvm.org/D86813#2797746>, @aprantl wrote:
>
>> Yes! Bugpoint can already reduce metadata — I'm wondering if this could maybe a mode of bugpoint in the future?
>
> On this topic, @n-omer will be doing something similar with llvm-reduce (starting imminently), largely inspired by the fact that llvm-reduce can cut an IR file down to one or two blocks and instructions, but leaves 20,000 DI metadata nodes untouched.
>
> (Maybe bugpoint and llvm-reduce are the same thing now? Either day, delta reduction is good).

Cool, I'll make an RFC later today, since we can taint this patch thread with this topic a lot :)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86813/new/

https://reviews.llvm.org/D86813