[PATCH] D103431: [AMDGPU] Fix missing lowering of LDS used in global scope.

[Jon Chesterfield via Phabricator via llvm-commits]

JonChesterfield added a comment.

In D103431#2791057 <https://reviews.llvm.org/D103431#2791057>, @hsmhsm wrote:

> If the current logic of shouldLowerLDSToStruct() is more robust compere to earlier ones, then, why cannot we use it, instead of patching-up earlier ones?

By current, you mean the code in this patch? It's not obvious to me that this patch is correct. I'm suspicious of branchy code with lots of comments. It looks like other people are already reviewing it, so hopefully they'll catch any other shortcomings.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103431/new/

https://reviews.llvm.org/D103431