[PATCH] D103304: Update and improve compiler-rt tests for -mllvm -asan_use_after_return=(never|[runtime]|always).

Dan Liew via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 3 22:31:21 PDT 2021


delcypher added a comment.

In D103304#2797811 <https://reviews.llvm.org/D103304#2797811>, @delcypher wrote:

> @kda This change has broken our internal builds on macOS. I'm not sure why it hasn't broken the public ones. If you add a new weak symbol it needs to be added to `lib/asan/weak_symbols.txt` so that the linker on macOS knowns it's okay for the symbol to not be defined. We'll put up a patch to fix this shortly.

@kda Seeing as this patch was reverted it doesn't make sense for me to put up a patch to fix it. If you try to reland this please update `lib/asan/weak_symbols.txt` as I mentioned in previous comments.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103304/new/

https://reviews.llvm.org/D103304



More information about the llvm-commits mailing list