[PATCH] D103459: [Demangle][Rust] Parse backreferences
David Blaikie via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 3 20:24:04 PDT 2021
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Looks good - probably 3 separate commits, though. (handy if they're separate reviews too in the future - just a bit easier to check tests, etc)
================
Comment at: llvm/lib/Demangle/RustDemangle.cpp:510-512
+ case 'B':
+ demangleBackref([&] { demangleType(); });
+ break;
----------------
Maybe split this in two - add the two different places for backrefs separately, with separate tests? Oh, three different places (also demangleConst)?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103459/new/
https://reviews.llvm.org/D103459
More information about the llvm-commits
mailing list