[PATCH] D103206: [ADT] Refactor enumerate unit tests

[David Blaikie via Phabricator via llvm-commits]

dblaikie added inline comments.


================
Comment at: llvm/unittests/ADT/STLExtrasTest.cpp:157
+  }
+  virtual ~Counted() { ++D; }
+};
----------------
Probably doesn't need to be virtual, if no one ever destroys it polymorphically? But I guess we have warnings enabled that make that problematic?

Could we use composition instead, then? (Range contains a Counted, rather than derives from?)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103206/new/

https://reviews.llvm.org/D103206