[PATCH] D103455: [yaml2obj] Add support for writing the long symbol name.

[Xing GUO via Phabricator via llvm-commits]

Higuoxing added inline comments.


================
Comment at: llvm/test/tools/yaml2obj/XCOFF/long-symbol-name.yaml:1
+# Test that StringTable works well for long symbol names.
+# RUN: yaml2obj %s -o %t
----------------
Nit: Usually, we use '##' for comments that are not RUN lines.


================
Comment at: llvm/test/tools/yaml2obj/XCOFF/long-symbol-name.yaml:18
+
+--- !XCOFF
+FileHeader:
----------------
1. Can you add a symbol with short symbol name to illustrate that long names are stored in the string table and short names are stored in the .debug section?

2. I think it's hard to tell whether a symbol name is from the string table or the .debug section in your test since llvm-readobj only prints the symbol name without mentioning where it's from. Are there any options for llvm-readobj that is able to tell us where the symbol name is from?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103455/new/

https://reviews.llvm.org/D103455