[PATCH] D103288: [SanCov] Properly set ABI parameter attributes

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

I was looking back to D101713 <https://reviews.llvm.org/D101713> where I found some crashing tests due to mismatched ABI attributes, specifically ones with type parameters like byval. The solution I had come up with was D101806 <https://reviews.llvm.org/D101806>, which was to ignore caller ABI attributes. We could also fix those crashes by also looking at the caller indirect ABI attribute type parameters.

I still think it's more consistent to only look at the callee parameter ABI attributes. It's weird that indirect and direct calls could be different. For example, ABI lowering could be different if an indirect call is promoted to a direct call with some ABI attributes not present on the call instruction. But it's less work to insert random calls to functions (especially compiler-rt functions or library calls) and not have to worry about ABI attributes. At this point I'm willing to give up on D101806 <https://reviews.llvm.org/D101806> and just go down the easier route of looking at the caller for the type parameters to byval/etc (and revert the changes I've made similar to this).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103288/new/

https://reviews.llvm.org/D103288