[PATCH] D103550: [SampleFDO] New hierarchical discriminator for FS SampleFDO (llvm-profdata part)

[Hongtao Yu via Phabricator via llvm-commits]

hoy added inline comments.


================
Comment at: llvm/tools/llvm-profdata/llvm-profdata.cpp:468
+               clEnumVal(PassLast, "Use all discriminator bits (default)")));
+static void setDiscriminatorMaskedBit(sampleprof::SampleProfileReader *Reader) {
+  Reader->setDiscriminatorMaskedBitFrom(FSDiscriminatorPassOption.getValue());
----------------
Nit: add a blank line above


================
Comment at: llvm/tools/llvm-profdata/llvm-profdata.cpp:572
   auto Reader = std::move(ReaderOrErr.get());
+  setDiscriminatorMaskedBit(Reader.get());
   if (std::error_code EC = Reader->read())
----------------
I'm wondering if this can be moved into `SampleProfileReader::create` with the mask as an extra parameter of it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103550/new/

https://reviews.llvm.org/D103550